Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Access] Update model Block REST API Response #6884

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[Access] Update model Block REST API Response #6884

wants to merge 8 commits into from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Jan 14, 2025 •
edited
Loading

Closes: #6874

Related PR:

Context

The omitempty tag was added to the Expandable field for Block, flow package version updated

@UlyanaAndrukhiv UlyanaAndrukhiv requested a review from a team as a code owner January 14, 2025 14:28
@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (a7d9a7f) to head (7e2b0b5).

Files with missing lines Patch % Lines
engine/access/rest/common/models/block.go 86.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6884      +/-   ##
==========================================
- Coverage   41.11%   41.09%   -0.02%     
==========================================
  Files        2125     2125              
  Lines      186264   186278      +14     
==========================================
- Hits        76583    76556      -27     
- Misses     103258   103294      +36     
- Partials     6423     6428       +5
Flag Coverage Δ
unittests 41.09% <86.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-assigned this Jan 22, 2025
peterargue
peterargue reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please update the import version to v0.4.9

go.mod Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue left review comments

@illia-malachyn illia-malachyn illia-malachyn approved these changes

@Guitarheroua Guitarheroua Awaiting requested review from Guitarheroua

At least 2 approving reviews are required to merge this pull request.

Assignees

@Guitarheroua Guitarheroua

@UlyanaAndrukhiv UlyanaAndrukhiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Access] Update model Block REST API Response
5 participants
@UlyanaAndrukhiv @codecov-commenter @Guitarheroua @peterargue @illia-malachyn